-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite with JuliaSyntax #870
Merged
Merged
+7,650
−5,877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…except some alignment ones and that's due to unicode length/ncodeunits stuff
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now passes all tests. This bumps the version up to v2.0.0 since, well, it is a complete rewrite and there are some breaking changes.
contintuation of #848
fixes
#767
#867
#862
#774
#241
#565
#876
CI to 1.10+
1.10 is the new LTS so we're dropping CI for earlier versions.
Whitespace for Operator Expressions (e.g.,
a + b
) (BREAKING)Formatting is now based on the source code, meaning
a+b
will remain asa+b
, while expressions with spaces will be formatted asa + b
(e.g.,a +b
becomesa + b
). This change provides users with greater flexibility in formatting. Previously, almost all expressions were separated by a single whitespace.Options related to whitespace around operators will function the same as before.
This change should have minimal impact on previously formatted code.
Semicolons (BREAKING)
We now track all semicolons to ensure they are always placed where present in the original code.
Multiline Comments (BREAKING)
Multiline comments, previously treated as inline comments or disregarded, are now preserved in their original form.
short_circuit_to_if
FixThis feature has been corrected. When a short circuit is the final expression, it will now be properly evaluated and converted to its full version. For example:
Now transforms to:
Previously, the last expression would have been incorrectly transformed to just
if b return "ooo" end
, omitting theelse
clause.